fix: better accuracy lanczos fourier-space interp#234
Merged
Conversation
Merging this PR will degrade performance by 33.32%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | test_benchmarks_lanczos_interp[kval-no_conserve_dc-run] |
291.2 µs | 436.8 µs | -33.32% |
Comparing test-fixes-4 (0bf5eee) with main (1e20520)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jax-galsim uses a lower-accuracy akima interpolant instead of a cubic spline when interpolating the k-space table for the fourier transform of the Lanczos interpolant. This causes a loss in accuracy. For jax-galsim, I am increasing the number of points being interpolated by 2.3x. The cost of computing the table comes at compile time, and it is cached on the CPU side, so we should not see big performance losses in most cases.
xref: GalSim-developers/GalSim-for-JAX-GalSim-Testing#9